Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make control allocation and actuator effectiveness a non-module-specific library #24196

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Jan 10, 2025

Solved Problem

When trying to implement a separate metric control allocation module, it seems that sharing the control allocation library seems like a sensible solution.

Solution

  • Make ControlAllocation and ActuatorEffectiveness a library that can be shared across multiple modules
  • Keep Vehicle Specific ActuatorEffectiveness implementation as part of control_allocator module and only keep the ActuatorEffectiveness base class in the library.

Changelog Entry

For release notes:

Feature/Bugfix XYZ
New parameter: XYZ_Z
Documentation: Need to clarify page ... / done, read docs.px4.io/...

Test coverage

Context

@Jaeyoung-Lim Jaeyoung-Lim force-pushed the pr-control-allocation-lib branch 2 times, most recently from 6e6108b to 0028f92 Compare January 10, 2025 16:21
@Jaeyoung-Lim Jaeyoung-Lim force-pushed the pr-control-allocation-lib branch from 0028f92 to a164aa7 Compare January 10, 2025 16:28
@Jaeyoung-Lim Jaeyoung-Lim changed the title Make control allocation and actuator effectiveness a library Make control allocation and actuator effectiveness a non module specific library Jan 10, 2025
@Jaeyoung-Lim Jaeyoung-Lim changed the title Make control allocation and actuator effectiveness a non module specific library Make control allocation and actuator effectiveness a non-module-specific library Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant