-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per board/target dds_topics.yaml configuration for uXRCE #23724
base: main
Are you sure you want to change the base?
Conversation
I'm certainly in favor of having customization mechanisms (for custom projects, etc), but at the moment I'm not a fan of it differing just for v6x like this. I think what we really need here is runtime configurability. |
In this case, the v6x variant is only there as an example. It doesn't have to be within the PR at all. Runtime configuration would mean we would need to build & assign a topic to all uOrb topics. That would be close to 230 messages, each to 1+ topics. How would you see runtime configurability? |
Thanks, I just want to be careful to keep things as consistent as possible between targets and avoid future surprises when those files inevitably diverge.
Yes that's one issue, we likely need both build time and runtime configurability (for the included subset that's actually in the build). One possible baby step is to start with a few presets (like mavlink modes) so at least we can get past trying to please everyone with radically different requirements. |
Another idea that just occurred to me regarding overriding the built in dds_topics.yaml would be to allow specifying that file in kconfig. Then the default would simply be For example here's how a board can set a custom mavlink dialect.
PX4-Autopilot/src/modules/mavlink/CMakeLists.txt Lines 60 to 79 in ba75b9c
|
You could take a look on how it's done for Zenoh, there it's both compile-time (generating serializers and datatypes) and runtime mapping datatypes/topics to zenoh (ros2) topic.s |
Or Mavlink's way: Configure the streams according to different default configurations. I am a bit worried on the amount of work the runtime mapping will take, in comparison to 7 lines. |
It's not one extreme or the other, first we can add this simple build time override mechanism immediately if it's actually helpful. I just don't want to carry an fmu-v6x difference that will likely diverge over time. I'm suggesting the runtime configurability because there are a few common cases that cover the vast majority. Some people/projects will want to fully customize data flow in each direction (custom dds_topics.yaml), but most won't want to or need to with a few presets. |
8e3801f
to
d100827
Compare
Indeed. I removed the example, as it is not required. |
c71b670
to
7f24d53
Compare
7f24d53
to
ba12460
Compare
Solved Problem
Solution
dds_config.yaml
fileThe selection goes as, for example
make px4_fmu-v6x_rover
boards/px4/fmu-v6x/rover_dds_topics.yaml
)boards/px4/fmu-v6x/default_dds_topics.yaml
)src/modules/uxrce_dds_client/dds_topics.yaml
)Changelog Entry
For release notes: