Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW Position Control: improve auto takeoff behavior without launch detection #23526

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Aug 9, 2024

Solved Problem

  1. when the airspeed measurement is negative, the input into the filter is TRIM airspeed, which results in a growing airspeed_filtered value even though the actual airspeed is still 0, plus it made the underspeed flag toggle between on and off.
  2. the airspeed underspeed logic shouldn't be active during takeoff (anyway not able to pitch down due to FW_TKO_PITCH_MIN)

image

Solution

  1. leave the airspeed validity logic to the airspeed validator, and use measurement in the FW position controller as long as finite.
  2. Disable airspeed underspeed detection logic during auto takeoff, as we already do for the landing for example.

Changelog Entry

For release notes:

Improvement: FW Position Control: improve auto takeoff behavior without launch detection

Test coverage

SITL tested.

@sfuhrer sfuhrer requested a review from RomanBapst August 9, 2024 12:29
@sfuhrer sfuhrer force-pushed the pr-fw-pos-airspeed-takeoff-validity-main branch from 37c8b64 to 70010df Compare August 9, 2024 12:30
@sfuhrer sfuhrer force-pushed the pr-fw-pos-airspeed-takeoff-validity-main branch from 4d7b014 to bc695a6 Compare August 12, 2024 08:44
bresch
bresch previously approved these changes Aug 13, 2024
@sfuhrer sfuhrer merged commit a0d22a4 into main Aug 13, 2024
93 of 95 checks passed
@sfuhrer sfuhrer deleted the pr-fw-pos-airspeed-takeoff-validity-main branch August 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants