battery: only reset soc filter with valid voltage measurement #23513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfriedrich98
force-pushed
the
battery_disconnect_reset
branch
from
19d9e1d
to
dd0fef8
Compare
sfuhrer
approved these changes
Aug 8, 2024
Claudio-Chies
pushed a commit
that referenced
this pull request
Aug 15, 2024
vertiq-jordan
pushed a commit
to iq-motion-control/PX4-Autopilot
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
If the battery is disconnected (voltage measurement below a hardcoded value of 2.1 V) even for just one sample it causes the SoC filter to reset with the current voltage measurement. This leads to the SoC dropping to 0 for one sample which triggers a battery failsafe.
Solution
Protect the state of charge filter from being reset when the battery is disconnected.