zenoh-pico: update to correct dev/1.0.0-px4 branch which is advertised by GitHub #23492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PX4 fork of Zenoh-pico is now up to date with Zenoh pico I would propose to point it to PX4/zenoh-pico@e6cdbf7 |
|
That is indeed, sorry for the mess up. |
|
ok, I'll do that 👍 |
MaEtUgR
force-pushed
the
zenoh-pico-correct-1.0.0-branch
branch
from
f56cbc5
to
a8ac322
Compare
|
CI failure that's related 😬 |
which is up to date containing "Use SO_REUSEPORT only if it exists" and is advertised by GitHub because the commit is on a branch
MaEtUgR
force-pushed
the
zenoh-pico-correct-1.0.0-branch
branch
from
a8ac322
to
7f4c8f8
Compare
|
Because of the build error with https://github.com/PX4/zenoh-pico/tree/dev/1.0.0 caught by CI that's related to eclipse-zenoh/zenoh-pico#563 and type casting I went back to my original suggestion referring to https://github.com/PX4/zenoh-pico/tree/dev/1.0.0-px4 instead. That will get main successfully fetch submodules again and you can look into the build issue and update to the latest 1.0.0 with more context than I have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
#23462 (comment)
Solution
Switch
zenoh-picosubmodule fromhttps://github.com/PX4/zenoh-pico/commits/fff1a8c168e10d4ed9cbf2aa7d67ede07f239c52
to
https://github.com/PX4/zenoh-pico/tree/dev/1.0.0-px4 (PX4/zenoh-pico@f093aa7)
Alternatives
Please check the versions in review. I'm only guessing that's what you wanted. FYI @AlexisTM
Test coverage
This submodule commit was advertised by GitHub and hence is available for me locally.