Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5_stackcheck: disable CONFIG_DRIVERS_TONE_ALARM #23278

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Jun 17, 2024

v5_stacktest is above the flash limit.

I'm not fully in the loop what this build is for, but with disabling the DRIVER_TONE_ALARM it passes again. Is it okay to exclude that from the build?

@sfuhrer sfuhrer requested a review from dagar June 17, 2024 13:12
@sfuhrer
Copy link
Contributor Author

sfuhrer commented Jun 17, 2024

@MaEtUgR fyi

Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't know what it's used for. From the name presumably to start all things at once and see if there's any RAM problem? Is tone alarm part of this? Should we instead kick out some other driver that's not part of the test?

@dagar dagar merged commit c0d693b into main Jun 17, 2024
92 of 93 checks passed
@dagar dagar deleted the pr-fix-v5_stacktest-flash-main branch June 17, 2024 16:26
@dagar
Copy link
Member

dagar commented Jun 17, 2024

It's a build of px4_fmu-v5 with NuttX CONFIG_ARMV7M_STACKCHECK enabled. It's somewhat helpful for catching stackoverflows before they lead to a more subtle failure, but due to the guards it adds the resulting build can be much slower with different stack usage, so it's not necessarily representative.

@dagar
Copy link
Member

dagar commented Jun 17, 2024

It's useful in the sense that if the px4_fmu-v5_stackcheck build can boot and run successfully (a stackoverflow with cause a hardfault) then the regular builds will almost certainly have sufficient stack allocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants