Matrix: print full matrix already if only one element is not symmetric #23253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor clang tidy failure.
|
Signed-off-by: Silvan Fuhrer <[email protected]>
sfuhrer
force-pushed
the
pr-matrix-print-all-elements-main
branch
from
f30ec2c
to
332f8c3
Compare
Ups that printf was purely for debug purposes, removed it. |
dagar
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #22629, found while working on #23245. It's quite hard to read a print of a matrix that omits some of the elements because they are symmetric at this very point, but not the full matrix is.
With current main:
After this PR:
