Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ekf2: fix symforce cmake code generation targets #23220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ekf2: fix symforce cmake code generation targets #23220

wants to merge 1 commit into from
+25 −38

Conversation

dagar
Copy link
Member

@dagar dagar commented Jun 3, 2024

  • if symforce available always regenerate in build and use output in build directory
  • add new helper target (ekf2_generate_symforce_default) to regenerate default in tree symforce output

@dagar
ekf2: fix symforce cmake code generation targets
d24d668 
 - if symforce available always regenerate in build and use output in
   build directory
 - add new helper target (ekf2_generate_symforce_default) to regenerate
   default in tree symforce output
@dagar dagar added the EKF2 label Jun 3, 2024
@dagar dagar requested a review from bresch June 3, 2024 15:50
@dagar
Copy link
Member Author

dagar commented Jun 12, 2024

TODO:

  • lockdown symforce version range
  • require symforce generation in build if mag, wind, terrain disabled (doesn't match pregenerated derivation)

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-june-12-2024/39209/1

@github-actions github-actions bot added the stale label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bresch bresch Awaiting requested review from bresch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
EKF2 stale
Projects
PX4 EKF
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @DronecodeBot