Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only close server when errno is not EINTR #23209

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

rowandempster
Copy link
Contributor

Solved Problem

When I try to run a startup script I found that the system() call for that startup script was triggering a daemon server error that shuts down the socket early. Looks like another developer had handled this case by trying to ignore the specific errno for that system() triggered error, but left the break of that socket while loop outside of that errno check.

Solution

Moved break into the if errno check

Changelog Entry

For release notes:

  • Fixed daemon server errno handling bug

@MaEtUgR MaEtUgR requested a review from julianoes June 3, 2024 13:00
@MaEtUgR
Copy link
Member

MaEtUgR commented Jun 3, 2024

That was here: https://github.com/PX4/PX4-Autopilot/pull/19800/files#diff-7095b8b5a8690a77f915261d055ee37c87ad5af70620ba3d74dd674f3a0327d1R153-R158

To be honest I don't understand the details here. WOuld need to start from scratch. Let's see if @julianoes or @bkueng have the context.

@bkueng bkueng merged commit bc51eb3 into PX4:main Jun 6, 2024
87 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants