lib/world_magnetic_model: fetch_noaa_table.py refactor and scaling improvements #23152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dagar
commented
May 17, 2024
•
dagar
commented
- update to NOAA grid API to build WMM table in one pass
- refactor declination/inclination/totalintensity table printing to shared method
- compute scaling factor to maximize resolution
|
I haven't yet included them here, but this can now be easily extended to include the WMM uncertainties. |
dagar
force-pushed
the
pr-world_magnetic_model_update
branch
from
5b59a96
to
f3a9f6c
Compare
dagar
force-pushed
the
pr-world_magnetic_model_update
branch
from
f3a9f6c
to
644eb4b
Compare
…provements - upate to NOAA grid API to build WMM table in one pass - refactor declination/inclination/totalintensity table printing to shared method - compute scaling factor to maximize resolution
dagar
force-pushed
the
pr-world_magnetic_model_update
branch
from
644eb4b
to
ccbae90
Compare
- this hopefully helps avoid accidental mis-use - try to clarify units everywhere
bresch
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.