[WIP] ARK Mosaic Standalone Septentrio Driver #23102
Open
+4,040
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a generic interface over the GPS drivers makes dedicated functionality for each driver harder. Move the Septentrio driver into its own module under the `gnss` driver directory, and let it have its own parameters for only the functionality it requires. This also helps with adding new features because they only need to be implemented for the driver that wants it, simplifying testing.
Add support for two receivers which was also present in the original GPS drivers. Also fix the reset command which didn't work.
This removes the SBF code from the common GPS drivers which frees up space to include the Septentrio driver module by default on some boards.
Add back parameters to choose baud rate and automatically detect baud rate to use in configuration.
Rewrite large parts from the original driver to make the code more understandable, maintainable, document more items, move related things into their own files and make the code more consistent.
AlexKlimaj
force-pushed
the
pr-ark-septentrio-extract
branch
from
9afb45d
to
8b31220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress based on #22904
It does not appear to be working currently.