Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcom AFBR update API to 1.5.6 #22848

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Broadcom AFBR update API to 1.5.6 #22848

merged 2 commits into from
Mar 9, 2024

Conversation

AlexKlimaj
Copy link
Member

@AlexKlimaj AlexKlimaj commented Mar 6, 2024

This PR upgrades the Barodcom AFBR API to 1.5.6. It looks like all of the changes from 1.4.4 were under the hood.

https://broadcom.github.io/AFBR-S50-API/migration_guide.html

Multicopter
https://review.px4.io/plot_app?log=fff4bf3d-1eae-4eb3-92e8-09afb7b547a6

VTOL
https://review.px4.io/plot_app?log=062cf510-f140-4a0c-88c0-29e2e8d5f2ed
https://review.px4.io/plot_app?log=b63a3d1a-9c85-4001-bfaa-6a06ba2d45af

AFBR-S50 Chip ID: 33906, API Version: 17104902 v1.5.6
AFBR-S50LV85D

nsh> afbrs50 status
afbrs50: sample interval: 15978 events, 20166.85us avg, min 17349us max 25548us 1847.278us rms
distance: 1.874m
dfm mode: 2
rate: 50 Hz
nsh> listener distance_sensor

TOPIC: distance_sensor
 distance_sensor
    timestamp: 327245046 (0.027603 seconds ago)
    device_id: 18 (Type: 0x00, SPI:2 (0x00))
    min_distance: 0.08000
    max_distance: 30.00000
    current_distance: 1.87300
    variance: 0.00000
    h_fov: 0.10472
    v_fov: 0.10472
    q: [0.00000, 0.00000, 0.00000, 0.00000] (Roll: 0.0 deg, Pitch: -0.0 deg, Yaw: 0.0 deg)
    signal_quality: 100
    type: 0
    orientation: 25

nsh>

@dagar
Copy link
Member

dagar commented Mar 7, 2024

Basic functionality is working but needs flight time.

Wait before merging?

@AlexKlimaj
Copy link
Member Author

Lets hold off until I can get some flight time on it.

@dagar dagar marked this pull request as draft March 7, 2024 16:10
@AlexKlimaj AlexKlimaj requested a review from dagar March 9, 2024 20:38
@AlexKlimaj
Copy link
Member Author

I think this is ready to merge.

@dagar dagar marked this pull request as ready for review March 9, 2024 21:40
@dagar dagar merged commit a80a5a9 into PX4:main Mar 9, 2024
88 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants