mantis-edu: remove duplicate RC define #22831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
approved these changes
Mar 4, 2024
I'm not sure if there's literally any chance of it being used again. Either way we definitely need to get to a point where we don't carry board specific hacks. |
|
I don't think it ever went anywhere, right? So we might as well purge it? |
It would just render the 30 drones we just set up a few weeks ago to test main incapable of testing main. That's where the attention for this pr comes from. I'd wait a bit for them to actually not get used anymore. |
|
Oh, well I didn't know about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
@lyraik found this duplicate define 🧹