Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create no airframe model file #22473

Closed
wants to merge 2 commits into from

Conversation

frede791
Copy link
Contributor

@frede791 frede791 commented Dec 1, 2023

Solved Problem

When using PX4-gazebo models as the sim models source directory I found that CMake warnings would be thrown for models that did not have their own airframe file but were still needed as part of the foundation of other models.

Solution

To prevent this from happening I have added a file that lists out all models that are allowed to not have an airframe file and CMake will not throw a warning for them.

Screenshot from 2023-12-01 10-22-14

The warning seen when building PX4 with models that do not have an airframe file.

@dagar dagar marked this pull request as draft December 1, 2023 16:03
@frede791 frede791 marked this pull request as ready for review December 1, 2023 16:41
@frede791 frede791 mentioned this pull request Dec 6, 2023
@frede791 frede791 marked this pull request as draft December 6, 2023 17:12
@junwoo091400 junwoo091400 added the Sim: gazebo Gazebo simulator (gz) label Dec 14, 2023
@frede791
Copy link
Contributor Author

Has been made redundant by #22467

@frede791 frede791 closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sim: gazebo Gazebo simulator (gz)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants