-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving gz into submodule #22437
moving gz into submodule #22437
Conversation
Signed-off-by: frederik <[email protected]>
@dagar Let me know what you think of this. This is another step in moving Gazebo models away from PX4. |
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-november-28-2023/35555/1 |
Can you have cmake add the submodule so that it doesn't need to be manually initialized? PX4-Autopilot/src/modules/simulation/simulator_mavlink/sitl_targets_flightgear.cmake Line 7 in a9213e3
Place it here so that it's only initialized if gz_bridge is in the build. https://github.com/PX4/PX4-Autopilot/blob/main/src/modules/simulation/gz_bridge/CMakeLists.txt |
Co-authored-by: Daniel Agar <[email protected]>
Signed-off-by: frederik <[email protected]>
@dagar amended Cmake to auto initialize the gz submodule |
has been made redundant by #22467 and can therefore be closed. |
Striving for greater autonomy between PX4 and Gazebo, this PR moves gazebo models and worlds into their own repository and adds them as a submodule in PX4. This is another step in separating PX4 and Gazebo. Furthermore, this PR moves the
tools
folder from the/simulation/gz/
folder to the/simulation
folder in order to not need it to import it as well.Solution
Moving gz models and worlds to their own submodule for greater autonomy.