added default working directory when no working directory is specified #22420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Nov 22, 2023
…ory only if PX4_SOURCE_DIR is defined
|
CI SITL tests are failing, need to investigate. |
Ensure that this executes regardless of whether PX4_SOURCE_DIR is defined or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
This fixes #22419, where the PX4-SITL instance dies due to wrong default working directory.
Solution
px4executableAlternatives
As a temporary fix without modifying the source code, I modified the px4 node in px4.launch to specify the working directory path explicitly, as shown below: