Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NaN(s) error in SH tests #209

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix NaN(s) error in SH tests #209

merged 1 commit into from
Aug 9, 2024

Conversation

aelligp
Copy link
Collaborator

@aelligp aelligp commented Aug 2, 2024

This tries to fix the constant errors on both GPU and CPU CI for shearheating. The tests pass both locally and if re-run on the CI.

Shearheating3D: Error During Test at /var/lib/buildkite-agent/builds/amdgpu1-luraess-com/julialang/justrelax-dot-jl/test/test_shearheating3D.jl:239
  Got exception outside of a @test
  NaN(s)

Current solution to the problem:

try
    iters, thermal = Shearheating3D(igg; nx=nx, ny=ny, nz=nz)
catch e
    @warn e
    try
       iters, thermal = Shearheating3D(igg; nx=nx, ny=ny, nz=nz)
    catch e2
       @warn e2
    end
 end

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@albert-de-montserrat albert-de-montserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged?

@albert-de-montserrat albert-de-montserrat merged commit b9d2729 into main Aug 9, 2024
12 checks passed
@albert-de-montserrat albert-de-montserrat deleted the pa-SHtests branch August 9, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants