-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abstraction for (SBML) models #133
Merged
+673
−296
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6b26c69
Add abstraction for models
dweindl 796d042
Use new Model in petab.Problem
dweindl 796219b
__init__.py
dweindl d200396
fix merge
dweindl 52f0ec0
TYPE_CHECKING
dweindl 0736225
Replace most sbml_model occurrences by new Model
dweindl d798652
doc
dweindl 9a34c74
..
dweindl e0b6e74
Deprecate petab.Problem.from_files
dweindl 2924c2c
Update petab.Problem to use Model
dweindl 507c196
Update to test_petab
dweindl 7d9dae8
Add model type constants; add type code to class; add list of known t…
dweindl 3d4cda5
Model.to_file
dweindl d8d1774
fixup, doc
dweindl ee977a7
cleanup assert_model_parameters_in_condition_or_parameter_table
dweindl c04a75d
Use petab.Model in parameter mapping
dweindl 69f826e
sbml_model->model
dweindl 9bc1e6f
cleanup
dweindl 4996699
Merge branch 'develop' into abstract_model
dweindl d540c47
fixup merge
dweindl 78251a0
Merge branch 'develop' into abstract_model
dweindl bb61a12
fix merge
dweindl 66e1bc4
Merge branch 'develop' into abstract_model
dweindl ed7c23c
is/are
dweindl 4dbcfe0
Update petab/models/model.py
dweindl 804188b
Update petab/models/model.py
dweindl 3b337b0
the
dweindl d66e18a
import
dweindl 5464928
fixup rename
dweindl 4dcf1f6
PARAMETER_SEPARATOR
dweindl a9bf397
Merge branch 'develop' into abstract_model
dweindl 49e518c
..
dweindl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add model type constants; add type code to class; add list of known t…
…ypes
commit 7d9dae8b4a8e885b4b7a0bce48c52b323c9f9383
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,5 @@ | ||
MODEL_TYPE_SBML = 'sbml' | ||
|
||
known_model_types = {MODEL_TYPE_SBML} | ||
|
||
from .model import Model # noqa F401 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be here or the constants file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer keeping it more modular, but could consider importing it in
petab.C