Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netcdf output #54

Merged
merged 5 commits into from
May 9, 2023
Merged

Netcdf output #54

merged 5 commits into from
May 9, 2023

Commits on May 5, 2023

  1. Initial test code for netcdf output

    Currently can write variables from scalar Domains only (this is not checked!)
    
    TODO
     - type conversion for attributes
     - read scalar domains
     - scalar variables in non-scalar domains
     - grids
    sjdaines committed May 5, 2023
    Configuration menu
    Copy the full SHA
    2c562be View commit details
    Browse the repository at this point in the history
  2. Add netcdf output for two grid types, CellSpace Variables

    Write out
        UnstructuredVectorGrid
        UnstructuredColumnGrid
    
        CellSpace variables at least for these two grids (one dimension 'cells')
    sjdaines committed May 5, 2023
    Configuration menu
    Copy the full SHA
    5f67765 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Work-in-progress implementing netcdf output

    Can now save/load
      PB.Grids.UnstructuredVectorGrid
      PB.Grids.UnstructuredColumnGrid
    
    TODO
     - cartesian grids
     - add test cases to PALEOexamples
     - update doc
    
     Known issues / limitations:
     - PALEO currently has no concept of constant (time independent)
       variables. As a workaround, test in `variable_is_constant`
       looks for variable attribute :datatype = Float64 (and checks data is constant),
       where this attribute usually means constant but can also be used to
       label variables that won't be included in an AD Jacobian
    
    - NamedDimension (used in UnstructuredColumnGrid and for Domain
      data_dims eg used for a wavelength grid) also includes FixedCoordinate
      variables, which may not be present in the output and may not even be
      uniquely names. As a workaround, for data_dims generate unique names and save/load an
      extra variable, for UnstructuredColumnGrid assume variable will be present
      (TODO this should be changed for consistency).
    
    - Coordinate variables are not labelled with CF etc attributes
    
    - UnstructuredColumnGrid uses a non-standard way of saving indices
      (similar to contiguous ragged array in the CF spec, but unlikely to
      be supported by other tools)
    sjdaines committed May 6, 2023
    Configuration menu
    Copy the full SHA
    f8ef66f View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. netcdf output updates

    - can now save/load most grid types, except CartesianArrayGrid
    - tests added to PALEOdev.jl
    - Jupyter notebooks with Python xarray examples added to PALEOdev.jl
    sjdaines committed May 8, 2023
    Configuration menu
    Copy the full SHA
    c059e9c View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    cef88ba View commit details
    Browse the repository at this point in the history