Netcdf output #54
Merged
Netcdf output #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently can write variables from scalar Domains only (this is not checked!) TODO - type conversion for attributes - read scalar domains - scalar variables in non-scalar domains - grids
Write out
UnstructuredVectorGrid
UnstructuredColumnGrid
CellSpace variables at least for these two grids (one dimension 'cells')
Can now save/load PB.Grids.UnstructuredVectorGrid PB.Grids.UnstructuredColumnGrid TODO - cartesian grids - add test cases to PALEOexamples - update doc Known issues / limitations: - PALEO currently has no concept of constant (time independent) variables. As a workaround, test in `variable_is_constant` looks for variable attribute :datatype = Float64 (and checks data is constant), where this attribute usually means constant but can also be used to label variables that won't be included in an AD Jacobian - NamedDimension (used in UnstructuredColumnGrid and for Domain data_dims eg used for a wavelength grid) also includes FixedCoordinate variables, which may not be present in the output and may not even be uniquely names. As a workaround, for data_dims generate unique names and save/load an extra variable, for UnstructuredColumnGrid assume variable will be present (TODO this should be changed for consistency). - Coordinate variables are not labelled with CF etc attributes - UnstructuredColumnGrid uses a non-standard way of saving indices (similar to contiguous ragged array in the CF spec, but unlikely to be supported by other tools)
- can now save/load most grid types, except CartesianArrayGrid - tests added to PALEOdev.jl - Jupyter notebooks with Python xarray examples added to PALEOdev.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add netCDF output using
PALEOmodel.OutputWriters.save_netcdfandPALEOmodel.OutputWriters.load_netcdf!.This solves several related problems:
This is now the recommended way to save/load model output. Use of Julia-specific
jld2output withPALEOmodel.OutputWriters.save_jld2andPALEOmodel.OutputWriters.load_jld2now emits a deprecation and future-compatibility warning.