Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(N-05) improve comments for modifiers #322

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

ggonzalez94
Copy link
Collaborator

@ggonzalez94 ggonzalez94 commented Oct 4, 2024

Resolves #318

I used the term helpers, but open to better wording if someone has suggestions. This touches the same file as #311, so we might need to update it after we merge that one.

@ggonzalez94 ggonzalez94 changed the title improve comments for modifiers fix(N0-5) improve comments for modifiers Oct 4, 2024
@ggonzalez94 ggonzalez94 changed the title fix(N0-5) improve comments for modifiers fix(N-05) improve comments for modifiers Oct 4, 2024
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like term helper.

Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ggonzalez94 ggonzalez94 linked an issue Oct 7, 2024 that may be closed by this pull request
1 task
@ggonzalez94 ggonzalez94 merged commit c056473 into v0.1.0 Oct 9, 2024
19 checks passed
@bidzyyys bidzyyys deleted the n-05-mislleading-modifiers branch October 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Audit]:N-05 Misleading Reference to Modifiers in Pausable Module
3 participants