Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audit]:N-05 Misleading Reference to Modifiers in Pausable Module #318

Closed
1 task done
ggonzalez94 opened this issue Oct 4, 2024 · 0 comments · Fixed by #322
Closed
1 task done

[Audit]:N-05 Misleading Reference to Modifiers in Pausable Module #318

ggonzalez94 opened this issue Oct 4, 2024 · 0 comments · Fixed by #322
Assignees

Comments

@ggonzalez94
Copy link
Collaborator

What is the feature you would like to see?

The Pausable module makes reference to modifiers before the when_not_paused and when_paused functions, but true modifiers are not supported by the Stylus SDK. Consider
changing the wording of these comments and any others in the codebase to ensure that there are references to features that are unique to Solidity.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@ggonzalez94 ggonzalez94 added type: feature New feature request. needs triage Needs to be assigned the appropriate labels labels Oct 4, 2024
@ggonzalez94 ggonzalez94 self-assigned this Oct 4, 2024
@ggonzalez94 ggonzalez94 added this to the Release v0.1.0 milestone Oct 4, 2024
@ggonzalez94 ggonzalez94 linked a pull request Oct 7, 2024 that will close this issue
@ggonzalez94 ggonzalez94 removed type: feature New feature request. needs triage Needs to be assigned the appropriate labels labels Oct 9, 2024
ggonzalez94 added a commit that referenced this issue Oct 9, 2024
Resolves #318 

I used the term `helpers`, but open to better wording if someone has
suggestions. This touches the same file as #311, so we might need to
update it after we merge that one.
@github-project-automation github-project-automation bot moved this from Todo to Done in Rust Contracts Stylus Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant