cpu-o3: refactor branch predictors latency #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinezyy
approved these changes
Sep 12, 2024
Lingrui98
reviewed
Sep 13, 2024
src/cpu/pred/ftb/ftb.hh
Outdated
| @@ -91,7 +91,7 @@ class DefaultFTB : public TimedBaseFTBPredictor | |||
|
|
|||
| void specUpdateHist(const boost::dynamic_bitset<> &history, FullFTBPrediction &pred) override; | |||
|
|
|||
| unsigned getDelay() override {return numDelay;} | |||
| unsigned getDelay() override { return numDelay; } | |||
There was a problem hiding this comment.
建议直接实现在基类里
Has it been resolved?
There was a problem hiding this comment.
I think, it has been solved (?
eastonman
force-pushed
the
refactor-predictors-latency
branch
from
f6ef857
to
9c41fdb
Compare
use params instead of hard coded magic number Change-Id: I252ba2c582c285b6a7051b9207c7a4542e8fe9aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use params instead of hard coded magic number
Change-Id: I252ba2c582c285b6a7051b9207c7a4542e8fe9aa