Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GUI module resource file resolution #177

Merged
merged 13 commits into from
Jul 6, 2023
Merged

Enable GUI module resource file resolution #177

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c7347a0
Refactors `GUIInterface` to send `page_names` containing GUI resource…
NeonDaniel Jul 5, 2023
f7f7ba3
Update logged deprecation warning
NeonDaniel Jul 5, 2023
c2c60ce
Upload GUI files as encoded bytes to support arbitrary file formats
NeonDaniel Jul 5, 2023
7d50921
Update unit tests to handle GUI files as bytes instead of text
NeonDaniel Jul 5, 2023
7c83c1a
Update logging and comments
NeonDaniel Jul 5, 2023
b41318a
Update GUI to send resource directories for GUI module resource resol…
NeonDaniel Jul 6, 2023
a034415
Refactor `skill_paths` to `ui_directories` since a GUI interface isn'…
NeonDaniel Jul 6, 2023
63f072c
Refactor page upload to remove extra `skill_id` in path
NeonDaniel Jul 6, 2023
fc4ee91
Add comment about file naming
NeonDaniel Jul 6, 2023
85e2988
Update unit tests to include case for uploading all GUI resource files
NeonDaniel Jul 6, 2023
fce76e7
Update `page` property docstring
NeonDaniel Jul 6, 2023
62e4cca
Move `get_ui_directories` method from workshop to `gui` module
NeonDaniel Jul 6, 2023
78de0c0
Drop `ui5`/`ui6` directory checks for paths that were never supported
NeonDaniel Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ovos_utils/gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,8 +795,8 @@ def _normalize_page_name(page_name: str) -> str:
file, ext = splitext(page_name)
if ext == ".qml":
log_deprecation("GUI resources should exclude gui-specific file "
"extensions. In the future, this may cause "
"unexpected behavior.", "0.1.0")
f"extensions. This call should probably pass "
f"`{file}`, instead of `{page_name}`", "0.1.0")
JarbasAl marked this conversation as resolved.
Show resolved Hide resolved
return file

return page_name
Expand Down
Loading