-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GUI module resource file resolution #177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IDs Adds unit tests for `GUIInterface` methods and updates docstrings
Codecov Report
@@ Coverage Diff @@
## dev #177 +/- ##
==========================================
+ Coverage 26.56% 27.66% +1.10%
==========================================
Files 49 49
Lines 6419 6456 +37
==========================================
+ Hits 1705 1786 +81
+ Misses 4714 4670 -44
|
JarbasAl
reviewed
Jul 5, 2023
Catch and handle errors in GUI file upload
JarbasAl
reviewed
Jul 5, 2023
…t necessarily a skill
JarbasAl
reviewed
Jul 6, 2023
JarbasAl
reviewed
Jul 6, 2023
Add unit tests for `get_ui_directories` Update default GUI path to support available `all` directory
JarbasAl
approved these changes
Jul 6, 2023
JarbasAl
reviewed
Jul 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
GUIInterface
to sendpage_names
containing GUI resource IDsAdds unit tests for
GUIInterface
methods and updates docstringsRefactors messagebus API to upload files as encoded binary for non-text resource support
Refactors
GUIInterface
to track page id's instead of file paths in the internalpages
propertyDescription of new behavior:
GUIInterface
was responsible for resolving an absolute file path for a requested resource and sending lists of paths to the GUI module. This behavior remains for backwards-compat. but should be considered deprecated.GUIInterface
now deals withpage_name
as an identifier, like other resources (i.e.gui_page
->gui_page.qt
asstop
->stop.voc
)..qml
extensions are removed for backwards-compat with skills that request page names following the current syntax.ui_directories
now supports a special caseall
key which should contain a directory with subdirectories for each supported gui framework (i.e.qt5
,qt6
).gui.page.show
andgui.page.delete
messages now includepage_names
data which is a list of pages by ID, so the GUI module can handle requests per-client/framework.page
keys remain for backwards-compat. but will be removed in the future since the paths contained there are framework-specific