Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audio service ducking default config #82

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

add audio service ducking default config #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d677f5
add audio service ducking default config
emphasize Dec 2, 2023
0a1315c
expand comment
emphasize Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ovos_config/mycroft.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,12 @@
"active": true
}
},
// audio service ducking - lowering volume of background audio when TTS or system sound
// is playing
// NOTE: If the TTS config 'pulse_duck' is set to true, this setting will be ignored
// and pulse audio role ducking will be used instead.
"duck": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we leave this as False by default for now? Kinda want the OCP sprint to be done before we change this, as i am introducing both "duck" and "cork" in there (volume change vs pause/unpause)


// DEPRECATED - this value is only used as a fallback when OCP is not installed
// OCP is a full fledged media player that handles everything from video to playlists
// it plugs into the audio service api to capture playback and provide backwards compat
Expand Down
Loading