add audio service ducking default config #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #82 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 10
Lines ? 810
Branches ? 0
=====================================
Hits ? 0
Misses ? 810
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JarbasAl
reviewed
Dec 3, 2023
| // is playing | ||
| // NOTE: If the TTS config 'pulse_duck' is set to true, this setting will be ignored | ||
| // and pulse audio role ducking will be used instead. | ||
| "duck": true, |
There was a problem hiding this comment.
can we leave this as False by default for now? Kinda want the OCP sprint to be done before we change this, as i am introducing both "duck" and "cork" in there (volume change vs pause/unpause)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately, audio service ducking was introduced to OpenVoiceOS/ovos-audio@0a3b034
This makes the audio service ducking the default configuration
("Audio service ducking" will be invalidated if
"pulse_duck": trueis configured, ie. pulse is taking over to perform said task.)