Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests and improvements to settings change callback #116

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

NeonDaniel
Copy link
Member

Refactor _handle_settings_file_change to ignore non-settings file changes
Add unit tests for settings filewatcher and file change callback
Potentially closes #91

…hanges

Add unit tests for settings filewatcher and file change callback
Potentially closes #91
@NeonDaniel NeonDaniel requested review from goldyfruit, a team and emphasize July 12, 2023 18:15
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #116 (3bf453c) into dev (0cdf027) will increase coverage by 58.66%.
The diff coverage is 79.25%.

@@            Coverage Diff             @@
##             dev     #116       +/-   ##
==========================================
+ Coverage   0.00%   58.66%   +58.66%     
==========================================
  Files         33       33               
  Lines       3173     3242       +69     
==========================================
+ Hits           0     1902     +1902     
+ Misses      3173     1340     -1833     
Impacted Files Coverage Δ
ovos_workshop/decorators/converse.py 0.00% <0.00%> (ø)
ovos_workshop/decorators/fallback_handler.py 0.00% <0.00%> (ø)
ovos_workshop/skills/active.py 100.00% <ø> (+100.00%) ⬆️
ovos_workshop/skills/decorators/__init__.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/converse.py 0.00% <0.00%> (ø)
...vos_workshop/skills/decorators/fallback_handler.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/killable.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/layers.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/ocp.py 0.00% <0.00%> (ø)
ovos_workshop/skills/intent_provider.py 0.00% <0.00%> (ø)
... and 18 more

... and 4 files with indirect coverage changes

@JarbasAl JarbasAl merged commit 1a3245c into dev Jul 13, 2023
12 checks passed
@JarbasAl JarbasAl deleted the TEST_SettingsCallback branch July 13, 2023 18:09
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since version 0.0.12a26, settings are not reloaded with my skill
2 participants