0.0.12 #127
Merged
0.0.12 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* ovos-bus-client + skillGui class in ovos_workshop * bump ovos-utils
* Update internal import to avoid deprecation warning Add `skill_id` to logged warnings to diagnose legacy behavior * Fix init kwarg handling in `OVOSSkill` subclasses * Refactor init for `initialize` backwards-compat. * Refactor CommonQuerySkill init to resolve deprecation warnings * Formatting cleanup * Fix fallback init bug Cleanup unused added import
Update unit tests to only upload coverage for one run
NeonDaniel
reviewed
Jul 20, 2023
| def dig_for_skill(max_records: int = 10): | ||
| from ovos_workshop.app import OVOSAbstractApplication | ||
| from ovos_workshop.skills import MycroftSkill | ||
| def dig_for_skill(max_records: int = 10) -> Optional[object]: |
There was a problem hiding this comment.
This should always return a BaseSkill
| (str) path to resource or None if no resource found | ||
| """ | ||
| # TODO: Deprecate in 0.1.0 | ||
| LOG.warning(f"This method has moved to `ovos_utils.file_utils` and will be" |
There was a problem hiding this comment.
This should use log_deprecation
| """ | ||
| return RuntimeRequirements() | ||
|
|
||
| @classproperty | ||
| def network_requirements(self): | ||
| def network_requirements(self) -> RuntimeRequirements: | ||
| LOG.warning("network_requirements renamed to runtime_requirements, " |
There was a problem hiding this comment.
Should use log_deprecation now
| # backwards compat with mycroft-core | ||
| self.bus.emit(msg.forward("active_skill_request", | ||
| data={"skill_id": self.skill_id})) | ||
| # TODO - remove soon |
| event.set() | ||
|
|
||
| self.bus.on("recognizer_loop:audio_output_end", handle_output_end) | ||
| event.wait(timeout=15) |
There was a problem hiding this comment.
This timeout should be configurable, i.e. in case we expect a particularly long output or several preceding outputs that need to be spoken first
| # migrate settings if needed | ||
| if not exists(self._settings_path) and \ | ||
| exists(self._old_settings_path): | ||
| LOG.warning("Found skill settings at pre-xdg location, " |
There was a problem hiding this comment.
Consider upgrading to log_deprecation
NeonDaniel
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
0.0.12a50 (2023-07-20)
Full Changelog
Merged pull requests:
0.0.12a49 (2023-07-20)
Full Changelog
Merged pull requests:
V0.0.12a48 (2023-07-20)
Full Changelog
Merged pull requests:
V0.0.12a47 (2023-07-19)
Full Changelog
Merged pull requests:
V0.0.12a46 (2023-07-15)
Full Changelog
Merged pull requests:
V0.0.12a45 (2023-07-14)
Full Changelog
Fixed bugs:
V0.0.12a44 (2023-07-13)
Full Changelog
Merged pull requests:
V0.0.12a43 (2023-07-13)
Full Changelog
Merged pull requests:
V0.0.12a42 (2023-07-13)
Full Changelog
Closed issues:
Merged pull requests:
V0.0.12a41 (2023-07-12)
Full Changelog
V0.0.12a40 (2023-07-12)
Full Changelog
Closed issues:
Merged pull requests:
default_shutdownwith unit tests #115 (NeonDaniel)V0.0.12a39 (2023-07-12)
Full Changelog
Closed issues:
Merged pull requests:
V0.0.12a38 (2023-07-12)
Full Changelog
Merged pull requests:
V0.0.12a37 (2023-07-10)
Full Changelog
Merged pull requests:
V0.0.12a36 (2023-07-10)
Full Changelog
Implemented enhancements:
V0.0.12a35 (2023-07-07)
Full Changelog
Merged pull requests:
V0.0.12a34 (2023-07-06)
Full Changelog
Merged pull requests:
SkillGUIwith unit tests #106 (NeonDaniel)V0.0.12a33 (2023-07-04)
Full Changelog
Fixed bugs:
V0.0.12a32 (2023-06-24)
Full Changelog
Implemented enhancements:
Closed issues:
V0.0.12a31 (2023-06-19)
Full Changelog
Fixed bugs:
V0.0.12a30 (2023-06-16)
Full Changelog
Merged pull requests:
V0.0.12a29 (2023-06-15)
Full Changelog
Merged pull requests:
V0.0.12a28 (2023-06-14)
Full Changelog
Fixed bugs:
V0.0.12a27 (2023-05-17)
Full Changelog
Merged pull requests:
V0.0.12a26 (2023-05-17)
Full Changelog
Implemented enhancements:
Closed issues:
V0.0.12a25 (2023-05-03)
Full Changelog
Fixed bugs:
V0.0.12a24 (2023-05-01)
Full Changelog
Implemented enhancements:
Merged pull requests:
V0.0.12a23 (2023-04-30)
Full Changelog
Fixed bugs:
Merged pull requests:
V0.0.12a22 (2023-04-30)
Full Changelog
Fixed bugs:
V0.0.12a21 (2023-04-30)
Full Changelog
Fixed bugs:
V0.0.12a20 (2023-04-26)
Full Changelog
Fixed bugs:
V0.0.12a19 (2023-04-26)
Full Changelog
Fixed bugs:
V0.0.12a18 (2023-04-25)
Full Changelog
Implemented enhancements:
V0.0.12a17 (2023-04-24)
Full Changelog
V0.0.12a16 (2023-04-22)
Full Changelog
Implemented enhancements:
V0.0.12a15 (2023-04-22)
Full Changelog
Merged pull requests:
V0.0.12a14 (2023-04-22)
Full Changelog
Merged pull requests:
V0.0.12a13 (2023-04-22)
Full Changelog
Fixed bugs:
V0.0.12a12 (2023-04-22)
Full Changelog
Fixed bugs:
V0.0.12a11 (2023-04-22)
Full Changelog
Implemented enhancements:
V0.0.12a10 (2023-04-21)
Full Changelog
Fixed bugs:
V0.0.12a9 (2023-04-21)
Full Changelog
Fixed bugs:
V0.0.12a8 (2023-04-21)
Full Changelog
Merged pull requests:
V0.0.12a7 (2023-04-20)
Full Changelog
Implemented enhancements:
V0.0.12a6 (2023-04-20)
Full Changelog
Merged pull requests:
V0.0.12a5 (2023-04-18)
Full Changelog
Merged pull requests:
V0.0.12a4 (2023-04-14)
Full Changelog
Implemented enhancements:
V0.0.12a3 (2023-04-05)
Full Changelog
Merged pull requests:
V0.0.12a2 (2023-03-02)
Full Changelog
Closed issues:
voc_listto the OvosSkill class #53Merged pull requests:
V0.0.12a1 (2023-03-02)
Full Changelog
Merged pull requests:
voc_listhelper function #54 (emphasize)V0.0.11 (2023-02-25)
Full Changelog
V0.0.11a6 (2023-02-25)
Full Changelog
Merged pull requests:
V0.0.11a5 (2023-02-09)
Full Changelog
Fixed bugs:
V0.0.11a4 (2023-02-09)
Full Changelog
Merged pull requests:
V0.0.11a3 (2023-02-02)
Full Changelog
Fixed bugs:
V0.0.11a2 (2023-01-30)
Full Changelog
V0.0.11a1 (2023-01-28)
Full Changelog
Fixed bugs:
V0.0.10 (2023-01-24)
Full Changelog
Merged pull requests:
V0.0.10a6 (2023-01-24)
Full Changelog
Merged pull requests:
V0.0.10a5 (2023-01-19)
Full Changelog
Fixed bugs:
__handle_stop#44 (NeonDaniel)V0.0.10a4 (2023-01-19)
Full Changelog
Merged pull requests:
settings#43 (NeonDaniel)V0.0.10a3 (2023-01-18)
Full Changelog
Merged pull requests:
V0.0.10a2 (2023-01-17)
Full Changelog
Implemented enhancements:
V0.0.10a1 (2022-12-15)
Full Changelog
Implemented enhancements:
V0.0.9 (2022-10-20)
Full Changelog
V0.0.9a1 (2022-10-20)
Full Changelog
Fixed bugs:
V0.0.8 (2022-10-19)
Full Changelog
V0.0.8a6 (2022-10-19)
Full Changelog
Merged pull requests:
V0.0.8a5 (2022-10-19)
Full Changelog
V0.0.8a4 (2022-10-19)
Full Changelog
Implemented enhancements:
V0.0.8a3 (2022-10-19)
Full Changelog
Implemented enhancements:
V0.0.8a2 (2022-10-19)
Full Changelog
Merged pull requests:
V0.0.8a1 (2022-09-13)
Full Changelog
Merged pull requests:
V0.0.7 (2022-07-29)
Full Changelog
V0.0.7a12 (2022-07-29)
Full Changelog
Merged pull requests:
V0.0.7a11 (2022-07-28)
Full Changelog
Implemented enhancements:
V0.0.7a10 (2022-07-22)
Full Changelog
Merged pull requests:
V0.0.7a9 (2022-06-09)
Full Changelog
V0.0.7a8 (2022-06-02)
Full Changelog
Fixed bugs:
V0.0.7a7 (2022-05-09)
Full Changelog
V0.0.7a6 (2022-05-09)
Full Changelog
V0.0.7a5 (2022-05-09)
Full Changelog
V0.0.7a4 (2022-05-07)
Full Changelog
V0.0.7a3 (2022-05-07)
Full Changelog
V0.0.7a2 (2022-05-07)
Full Changelog
Merged pull requests:
V0.0.7a1 (2022-05-07)
Full Changelog
V0.0.6 (2022-03-03)
Full Changelog
V0.0.6a1 (2022-03-03)
Full Changelog
V0.0.5 (2022-02-25)
Full Changelog
V0.0.5a12 (2022-02-25)
Full Changelog
* This Changelog was automatically generated by github_changelog_generator