Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locking around skill settings changes #114

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add locking around skill settings changes #114

merged 1 commit into from
Jul 12, 2023

Conversation

NeonDaniel
Copy link
Member

Add test case to reproduce/resolve #93
Possibly related to #91

Add test case to reproduce/resolve #93
Possibly related to #91
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #114 (759ec42) into dev (0cdf027) will increase coverage by 58.34%.
The diff coverage is 76.25%.

@@            Coverage Diff             @@
##             dev     #114       +/-   ##
==========================================
+ Coverage   0.00%   58.34%   +58.34%     
==========================================
  Files         33       33               
  Lines       3173     3222       +49     
==========================================
+ Hits           0     1880     +1880     
+ Misses      3173     1342     -1831     
Impacted Files Coverage Δ
ovos_workshop/decorators/converse.py 0.00% <0.00%> (ø)
ovos_workshop/decorators/fallback_handler.py 0.00% <0.00%> (ø)
ovos_workshop/skills/active.py 100.00% <ø> (+100.00%) ⬆️
ovos_workshop/skills/decorators/__init__.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/converse.py 0.00% <0.00%> (ø)
...vos_workshop/skills/decorators/fallback_handler.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/killable.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/layers.py 0.00% <0.00%> (ø)
ovos_workshop/skills/decorators/ocp.py 0.00% <0.00%> (ø)
ovos_workshop/skills/intent_provider.py 0.00% <0.00%> (ø)
... and 13 more

... and 9 files with indirect coverage changes

@JarbasAl JarbasAl merged commit 6449aa2 into dev Jul 12, 2023
12 checks passed
@JarbasAl JarbasAl deleted the FIX_SettingsInit branch July 12, 2023 17:08
NeonDaniel added a commit that referenced this pull request Jul 13, 2023
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When core restarts, I got this trace in the "hello world" skill
2 participants