Skills module tests, docstrings, and annotations #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup, document, and test active and auto_translatable skill modules
Codecov Report
@@ Coverage Diff @@
## dev #108 +/- ##
==========================================
+ Coverage 0.00% 57.67% +57.67%
==========================================
Files 33 33
Lines 3173 3213 +40
==========================================
+ Hits 0 1853 +1853
+ Misses 3173 1360 -1813
|
Add deprecation log to layers.py Update docstrings, type annotations, and deprecation warnings in mycroft_skill.py Refactor `MycroftSkill` tests to a separate module to separate legacy code in tests
JarbasAl
reviewed
Jul 8, 2023
Add type annotations to OVOSSkill methods
Refactor `sleep` to `Event.wait()`
JarbasAl
approved these changes
Jul 10, 2023
JarbasAl
added
documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log deprecation for backwards-compat references
Reorganizes unit tests to separate legacy tests ported from
mycroft-coreAdds type annotations and docstrings to methods within the
skillsmoduleAdds init tests to all classes to validate expected parameters and properties
Stubs tests for skill methods to be filled in over time