Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove 'Gmail' from list for #2854" #2866

Merged
merged 5 commits into from
Jan 27, 2025
Merged

fix: remove 'Gmail' from list for #2854" #2866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96ec612
fix: remove 'Gmail' from list for #2854"
taylordowns2000 Jan 24, 2025
bba7663
update for Collections
taylordowns2000 Jan 24, 2025
42bae33
remove IO inspect
taylordowns2000 Jan 24, 2025
46c76e3
Fixup
stuartc Jan 27, 2025
7fda196
Merge remote-tracking branch 'origin/main' into 2854
stuartc Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ and this project adheres to
- Bump PostCSS [#2863](https://github.com/OpenFn/lightning/pull/2863)
- Replaced HTTPoison with Tesla in the AdaptorRegistry.
[#2861](https://github.com/OpenFn/lightning/pull/2861)
- Remove googlesheets, gmail and collections from credential schemas list
[#2854](https://github.com/OpenFn/lightning/issues/2854)

### Fixed

Expand Down
6 changes: 3 additions & 3 deletions lib/lightning_web/live/credential_live/credential_form_component.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,10 +600,10 @@ defmodule LightningWeb.CredentialLive.CredentialFormComponent do
end)

schemas_options
|> Enum.reject(fn {_, name, _, _} ->
name in ["googlesheets", "gmail", "collections"]
end)
|> Enum.concat([{"Raw JSON", "raw", nil, nil}])
# TODO: Gracefully determine which adaptors define custom credential types
# and which adaptors use OAuth2 credential types.
|> List.delete({"Googlesheets", "googlesheets", nil, nil})
|> Enum.sort_by(& &1, :asc)
end

Expand Down