Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove 'Gmail' from list for #2854" #2866

Merged
merged 5 commits into from
Jan 27, 2025
Merged

fix: remove 'Gmail' from list for #2854" #2866

merged 5 commits into from
Jan 27, 2025

Conversation

taylordowns2000
Copy link
Member

@taylordowns2000 taylordowns2000 commented Jan 24, 2025

This fixes #2854 (the other part of that issue—Hubtel—will be resolved by the next build) and closes the bug.

The open question is how to handle this TODO for the future @elias-ba , @stuartc . (Don't think this is high priority, but will come up again next time we add another OAuth based adaptor, @theroinaochieng .)

See here.

    schemas_options
    |> Enum.concat([{"Raw JSON", "raw", nil, nil}])
    # TODO: Gracefully determine which adaptors define custom credential types
    # and which adaptors use OAuth2 credential types.
    |> List.delete({"Googlesheets", "googlesheets", nil, nil})
    |> List.delete({"Gmail", "gmail", nil, nil})
    |> Enum.sort_by(& &1, :asc)

Please feel free to open an issue and prioritize as you see fit!

Copy link
Contributor

@elias-ba elias-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, Flash !

download

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.41%. Comparing base (acc7f12) to head (7fda196).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2866   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files         340      340           
  Lines       12267    12268    +1     
=======================================
+ Hits        11214    11215    +1     
  Misses       1053     1053           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartc stuartc requested review from stuartc and removed request for christad92 January 27, 2025 11:54
@stuartc stuartc merged commit adba8f6 into main Jan 27, 2025
8 checks passed
@stuartc stuartc deleted the 2854 branch January 27, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Strange behaviour for credential types
3 participants