Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update axios to latest version #770

Merged
merged 4 commits into from
Oct 9, 2024
Merged

update axios to latest version #770

merged 4 commits into from
Oct 9, 2024

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Oct 4, 2024

Summary

Update axios version to 1.7.7 for

dhis2
godata
mailchimp
openfn
progres
rapidpro
salesforce

Fixes #

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

@mtuchi
Copy link
Collaborator Author

mtuchi commented Oct 4, 2024

Unit test are passing but i am not sure if that is enough because some of the adaptors do not have unit test 🤔

@mtuchi mtuchi marked this pull request as ready for review October 4, 2024 07:45
@josephjclark
Copy link
Collaborator

Hi @aleksa-krolls, @christad92:

There is a very low risk of some of these adaptors breaking as a result of this PR. If any of these were to break, would anyone be upset?

godata
openfn
progres
rapidpro

@josephjclark
Copy link
Collaborator

@mtuchi Nice, I'm glad that dhis2 looks good.

I think so long as dhis2, salesforce and mailchimp are OK, this is worth the risk and I'm happy to merge. Even if we do break something it should be easy for users to to roll back a patch. But I'm just checking in with the adults first.

PS: Please update the AI disclosure 🙏

@josephjclark josephjclark changed the base branch from main to release/next October 5, 2024 08:12
@mtuchi
Copy link
Collaborator Author

mtuchi commented Oct 7, 2024

@josephjclark i have updated the AI usage and fixed the merge conflict

Base automatically changed from release/next to main October 9, 2024 09:38
Copy link
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtuchi when the build is restored this will need rebasing and bumping.

Please bump the versions and re-assign me to release. Thanks!

@mtuchi
Copy link
Collaborator Author

mtuchi commented Oct 9, 2024

Hiya @josephjclark i have bump version and push the changes. But i am noticing modification in this file packages/fhir-ndr-et/src/builders.js. Is this expected ? I haven't pushed the tags yet, let me know if i should do so

@mtuchi mtuchi mentioned this pull request Oct 9, 2024
@josephjclark
Copy link
Collaborator

@mtuchi Are you sure you used the very latest main? #777 was merged very recently and it should have the same diff. I suspect GH is lying but please double check your main

We've got a bit of a problem in fhir-ndr-et #776 which I'll fix next week, which will cause this sort of thing to happen :(

@mtuchi
Copy link
Collaborator Author

mtuchi commented Oct 9, 2024

@josephjclark My latest commit on main is ffa10a8 after git pull, when i run pnpm i && pnpm build it modified: packages/fhir-ndr-et/src/builders.js

@josephjclark
Copy link
Collaborator

Urgh. I think I know what this is. I'm gonna have to raise a quick fix - bear with me 🙏

@josephjclark
Copy link
Collaborator

@mtuchi OK I've updated main. Can you please revert the changes to fhir-ndr-et and merge main?

This should get rid of these strange diffs.

@mtuchi
Copy link
Collaborator Author

mtuchi commented Oct 9, 2024

@josephjclark i have revert the changes on fhir-ndr-et, i will push tags shortly and merge to main

@mtuchi mtuchi merged commit 866ed91 into main Oct 9, 2024
2 checks passed
@mtuchi mtuchi deleted the update-axios branch October 9, 2024 16:04
@josephjclark
Copy link
Collaborator

Thank you @mtuchi ! Remember that tags are automated now. No need to push manually.

@mtuchi
Copy link
Collaborator Author

mtuchi commented Oct 9, 2024

Ooh thank you kindly for the reminder, that is really good news 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants