-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update axios to latest version #770
Conversation
Unit test are passing but i am not sure if that is enough because some of the adaptors do not have unit test 🤔 |
Hi @aleksa-krolls, @christad92: There is a very low risk of some of these adaptors breaking as a result of this PR. If any of these were to break, would anyone be upset?
|
@mtuchi Nice, I'm glad that dhis2 looks good. I think so long as dhis2, salesforce and mailchimp are OK, this is worth the risk and I'm happy to merge. Even if we do break something it should be easy for users to to roll back a patch. But I'm just checking in with the adults first. PS: Please update the AI disclosure 🙏 |
@josephjclark i have updated the AI usage and fixed the merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtuchi when the build is restored this will need rebasing and bumping.
Please bump the versions and re-assign me to release. Thanks!
Hiya @josephjclark i have bump version and push the changes. But i am noticing modification in this file |
@josephjclark My latest commit on main is ffa10a8 after git pull, when i run |
Urgh. I think I know what this is. I'm gonna have to raise a quick fix - bear with me 🙏 |
@mtuchi OK I've updated main. Can you please revert the changes to This should get rid of these strange diffs. |
@josephjclark i have revert the changes on |
Thank you @mtuchi ! Remember that tags are automated now. No need to push manually. |
Ooh thank you kindly for the reminder, that is really good news 😃 |
Summary
Update axios version to
1.7.7
forFixes #
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.