Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axios: bump version to 0.28 #727

Closed
josephjclark opened this issue Aug 16, 2024 · 5 comments
Closed

axios: bump version to 0.28 #727

josephjclark opened this issue Aug 16, 2024 · 5 comments
Assignees

Comments

@josephjclark
Copy link
Collaborator

I'd like to bump axios versions to 0.28 across the repo. This will clear out some security notifications (it won't of course affect production releases).

The affected adaptors would be:

dhis2
godata
mailchimp
openfn
progres
rapidpro
salesforce

Some big tickets there. We can ignore salesforce as axios will be dropped soon anyway.

The 0.x changelog does report some breaking changes: https://github.com/axios/axios/blob/main/CHANGELOG.md

They look subtle. There's some stuff around formdata which makes me nervous.

I think the thing to do is to bump axios, and put a warning in the patch notes that the axios version changed. If any problems are introduced, we'll just have to fix them on demand.

This was referenced Aug 16, 2024
@josephjclark
Copy link
Collaborator Author

Axios 0.28.0 breaks paramSerializer, which breaks DHIS2.

I don't know what else broke, but I am very grateful to DHIS2's unit tests 🙏

@mtuchi
Copy link
Collaborator

mtuchi commented Oct 4, 2024

I wish we can remove all axios export first. Eg in salesforce then we can slowly plan a refactor for adaptor that uses axios in their functions

@mtuchi
Copy link
Collaborator

mtuchi commented Oct 4, 2024

I have updated axios to latest version 1.7.7. See #770

@josephjclark josephjclark changed the title axios: bump verision to 0.28 axios: bump version to 0.28 Oct 5, 2024
@aleksa-krolls
Copy link
Member

hey @mtuchi @josephjclark can we close this out?

@mtuchi
Copy link
Collaborator

mtuchi commented Oct 25, 2024

@aleksa-krolls this is done, let me close it

@mtuchi mtuchi closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants