-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
axios: bump version to 0.28 #727
Comments
Axios 0.28.0 breaks I don't know what else broke, but I am very grateful to DHIS2's unit tests 🙏 |
I wish we can remove all |
I have updated axios to latest version |
hey @mtuchi @josephjclark can we close this out? |
@aleksa-krolls this is done, let me close it |
I'd like to bump axios versions to 0.28 across the repo. This will clear out some security notifications (it won't of course affect production releases).
The affected adaptors would be:
Some big tickets there. We can ignore salesforce as axios will be dropped soon anyway.
The 0.x changelog does report some breaking changes: https://github.com/axios/axios/blob/main/CHANGELOG.md
They look subtle. There's some stuff around formdata which makes me nervous.
I think the thing to do is to bump axios, and put a warning in the patch notes that the axios version changed. If any problems are introduced, we'll just have to fix them on demand.
The text was updated successfully, but these errors were encountered: