Skip to content

Create PDO/RDO definitions #11

Create PDO/RDO definitions

Create PDO/RDO definitions #11

Triggered via pull request February 7, 2025 17:27
Status Success
Total duration 49s
Artifacts

check.yml

on: pull_request
commit_list
4s
commit_list
Matrix: clippy
Matrix: ubuntu / stable / deny
Matrix: nightly / doc
Matrix: nightly / fmt
Matrix: ubuntu / stable / features
Matrix: msrv
Fit to window
Zoom out
Zoom in

Annotations

2 errors
stable / clippy (c0f1d91b389fe849cfd6dc19f03f6281147811ab): src/pdo/mod.rs#L74
[clippy] reported by reviewdog 🐶 error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/pdo/mod.rs:74:1 | 74 | impl Into<u8> for ApdoKind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `-F clippy::from-over-into` implied by `-F clippy::style` help: replace the `Into` implementation with `From<pdo::ApdoKind>` | 74 ~ impl From<ApdoKind> for u8 { 75 ~ fn from(val: ApdoKind) -> Self { 76 ~ match val { | Raw Output: src/pdo/mod.rs:74:1:e:error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/pdo/mod.rs:74:1 | 74 | impl Into<u8> for ApdoKind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `-F clippy::from-over-into` implied by `-F clippy::style` help: replace the `Into` implementation with `From<pdo::ApdoKind>` | 74 ~ impl From<ApdoKind> for u8 { 75 ~ fn from(val: ApdoKind) -> Self { 76 ~ match val { | __END__
beta / clippy (c0f1d91b389fe849cfd6dc19f03f6281147811ab): src/pdo/mod.rs#L74
[clippy] reported by reviewdog 🐶 error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/pdo/mod.rs:74:1 | 74 | impl Into<u8> for ApdoKind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `-F clippy::from-over-into` implied by `-F clippy::style` help: replace the `Into` implementation with `From<pdo::ApdoKind>` | 74 ~ impl From<ApdoKind> for u8 { 75 ~ fn from(val: ApdoKind) -> Self { 76 ~ match val { | Raw Output: src/pdo/mod.rs:74:1:e:error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> src/pdo/mod.rs:74:1 | 74 | impl Into<u8> for ApdoKind { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `-F clippy::from-over-into` implied by `-F clippy::style` help: replace the `Into` implementation with `From<pdo::ApdoKind>` | 74 ~ impl From<ApdoKind> for u8 { 75 ~ fn from(val: ApdoKind) -> Self { 76 ~ match val { | __END__