Create PDO/RDO definitions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertZ2011
requested review from
akshat2112,
tullom,
JamesHuard,
huseinmsft,
gjpmsft and
madeleyneVaca
felipebalbi
requested changes
Feb 7, 2025
RobertZ2011
force-pushed
the
create-pdo
branch
from
c0f1d91 to
64dff72
Compare
RobertZ2011
force-pushed
the
create-pdo
branch
from
64dff72 to
1cc5e09
Compare
RobertZ2011
force-pushed
the
create-pdo
branch
from
1cc5e09 to
7eaa465
Compare
jerrysxie
approved these changes
Feb 11, 2025
felipebalbi
reviewed
Feb 11, 2025
u16 is too small and can overflow.
felipebalbi
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.