Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Fix filters layout is incorrect in feeds (#4646) #4651

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[frontend] Fix filters layout is incorrect in feeds (#4646) #4651

merged 1 commit into from
Oct 18, 2023

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Oct 18, 2023 •
edited
Loading

Proposed changes

  • change margin for padding, tested on streams / feeds / taxii. Triggers are displayed correctly already (because there is a span around the filters div)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Oct 18, 2023
@SouadHadjiat SouadHadjiat linked an issue Oct 18, 2023 that may be closed by this pull request
Filters layout is incorrect in feeds #4646
Closed
@SouadHadjiat SouadHadjiat marked this pull request as ready for review October 18, 2023 15:04
@SamuelHassine SamuelHassine merged commit 7ea2863 into master Oct 18, 2023
6 checks passed
@SamuelHassine SamuelHassine deleted the issue/4646 branch October 18, 2023 15:32
@SouadHadjiat SouadHadjiat mentioned this pull request Oct 19, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelHassine SamuelHassine SamuelHassine approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filters layout is incorrect in feeds
2 participants
@SouadHadjiat @SamuelHassine