Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters layout is incorrect in feeds #4646

Closed
SamuelHassine opened this issue Oct 18, 2023 · 3 comments · Fixed by #4651 or #4672
Closed

Filters layout is incorrect in feeds #4646

SamuelHassine opened this issue Oct 18, 2023 · 3 comments · Fixed by #4651 or #4672
Assignees
@SouadHadjiat
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 5.11.5

Comments

@SamuelHassine
Copy link
Member

Description

Filters layout is incorrect in feeds:

image

image

Same for CSV / Streams / TAXII. May also be in triggers.
@SamuelHassine SamuelHassine added the bug use for describing something not working as expected label Oct 18, 2023
@SamuelHassine SamuelHassine added this to the Release 5.11.5 milestone Oct 18, 2023
@SouadHadjiat SouadHadjiat self-assigned this Oct 18, 2023
SouadHadjiat added a commit that referenced this issue Oct 18, 2023
@SouadHadjiat
[frontend] Fix filters layout is incorrect in feeds (#4646)
596ddeb
@SouadHadjiat SouadHadjiat mentioned this issue Oct 18, 2023
Merged
5 tasks
@SouadHadjiat SouadHadjiat linked a pull request Oct 18, 2023 that will close this issue
[frontend] Fix filters layout is incorrect in feeds (#4646) #4651
Merged
5 tasks
SamuelHassine pushed a commit that referenced this issue Oct 18, 2023
@SouadHadjiat
[frontend] Fix filters layout is incorrect in feeds (#4646)
7ea2863
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 18, 2023
@SamuelHassine
Copy link
Member Author

@SouadHadjiat: still happening on retention policies (Settings => Customization => Retention policies):

image

Is it a more global problem we have broken in the refactor of the drawer by @Kedae?

@SamuelHassine SamuelHassine reopened this Oct 19, 2023
@SamuelHassine SamuelHassine removed the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 19, 2023
@Kedae
Copy link
Member

Kedae commented Oct 19, 2023 •
edited
Loading

Nop we had that before, I checked.

The issue with the alignment the first time, but if you close and come back usually it's better. I haven't investiguated far

@SouadHadjiat
Copy link
Member

@SouadHadjiat: still happening on retention policies (Settings => Customization => Retention policies):

image

Is it a more global problem we have broken in the refactor of the drawer by @Kedae?

Oh I thought I checked everywhere :( I can open another PR to fix it for retention policies

SouadHadjiat added a commit that referenced this issue Oct 19, 2023
@SouadHadjiat
[frontend] Fix filters layout in retention creation / edition (#4646)
67e0d6f
@SouadHadjiat SouadHadjiat mentioned this issue Oct 19, 2023
Merged
5 tasks
@SouadHadjiat SouadHadjiat linked a pull request Oct 19, 2023 that will close this issue
[frontend] Fix filters layout in retention creation / edition (#4646) #4672
Merged
5 tasks
SamuelHassine pushed a commit that referenced this issue Oct 19, 2023
@SouadHadjiat
[frontend] Fix filters layout in retention creation / edition (#4646)
0abc478
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouadHadjiat SouadHadjiat

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 5.11.5
3 participants
@SouadHadjiat @SamuelHassine @Kedae