-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deployment] improve breaking changes documentation #209
Open
labo-flg
wants to merge
4
commits into
main
Choose a base branch
from
oob/improve-breaking-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -4,53 +4,49 @@ This section lists breaking changes introduced in OpenCTI, per version starting | |||||||||
|
||||||||||
Please follow the migration guides if you need to upgrade your platform. | ||||||||||
|
||||||||||
## OpenCTI 6.2 | ||||||||||
|
||||||||||
### Change to the observable "promote" | ||||||||||
|
||||||||||
The API calls that promote an Observable to Indicator now return the created Indicator instead of the original Observable. | ||||||||||
## Breakdown per version | ||||||||||
|
||||||||||
**GraphQL API** | ||||||||||
This table regroups all the breaking changes introduced, with the corresponding version in which the change was implemented. | ||||||||||
|
||||||||||
* Mutation `StixCyberObservableEditMutations.promote` is now deprecated | ||||||||||
* New Mutation `StixCyberObservableEditMutations.promoteToIndicator` introduced | ||||||||||
| Change | Deprecated in | Changed in | | ||||||||||
|:-----------------------------------------------------------------|:--------------|:-----------| | ||||||||||
| [Promote Observable API](#change-to-the-observable-promote-API) | 6.2 | 6.5 | | ||||||||||
| [SAML authentication parameters](#change-to-SAML-authentication) | | 6.2 | | ||||||||||
| [Major changes to Filtering API](#new-filtering-API) | | 5.12 | | ||||||||||
|
||||||||||
|
||||||||||
**Client-Python API** | ||||||||||
|
||||||||||
* Client-python method `client.stix_cyber_observable.promote_to_indicator` is now deprecated | ||||||||||
* New Client-python method `client.stix_cyber_observable.promote_to_indicator_v2` introduced | ||||||||||
|
||||||||||
## OpenCTI 6.2 | ||||||||||
|
||||||||||
!!! warning "Discontinued Support" | ||||||||||
### Deprecation | ||||||||||
|
||||||||||
Please note that the deprecated methods will be permanently removed in OpenCTI 6.5. | ||||||||||
<a id="change-to-the-observable-promote-API"></a> | ||||||||||
#### Change to the observable promote API | ||||||||||
|
||||||||||
#### How to migrate | ||||||||||
|
||||||||||
If you are using custom scripts that make use of the deprecated API methods, please update these scripts. | ||||||||||
The API calls that promote an Observable to Indicator now return the created Indicator instead of the original Observable. | ||||||||||
|
||||||||||
The changes are straightforward: if you are using the return value of the method, you should now expect the new Indicator | ||||||||||
instead of the Observable being promoted; adapt your code accordingly. | ||||||||||
For more details, see [this migration guide](./breaking-changes/6.2-promote-to-indicator.md). | ||||||||||
|
||||||||||
### Breaking Changes | ||||||||||
|
||||||||||
<a id="change-to-SAML-authentication"></a> | ||||||||||
### Change to SAML authentication | ||||||||||
|
||||||||||
When `want_assertions_signed` and `want_authn_response_signed` SAML parameter are not present in OpenCTI configuration, | ||||||||||
the default is now set to `true` by the underlying library (passport-saml) when previously it was `false` by default. | ||||||||||
Upgrading `passport-saml` library introduced a breaking change with respect to the default SAML parameters regarding signing responses and assertions. | ||||||||||
|
||||||||||
For more details, see [this migration guide](./breaking-changes/6.2-saml-authentication.md). | ||||||||||
|
||||||||||
#### How to migrate | ||||||||||
|
||||||||||
If you have issues after upgrade, you can try with both parameters set to `false`. | ||||||||||
Comment on lines
55
to
58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
## OpenCTI 5.12 | ||||||||||
|
||||||||||
### Major changes to the filtering APi | ||||||||||
### Breaking changes | ||||||||||
|
||||||||||
OpenCTI 5.12 introduces a major rework of the **filter engine** with breaking changes to the model. | ||||||||||
<a id="new-filtering-API"></a> | ||||||||||
#### Major changes to the filtering API | ||||||||||
|
||||||||||
OpenCTI 5.12 introduces a major rework of the **filter engine** with breaking changes to the model. | ||||||||||
A [dedicated blog post](https://blog.filigran.io/introducing-advanced-filtering-possibilities-in-opencti-552147565faf) describes the reasons behind these changes. | ||||||||||
|
||||||||||
#### How to migrate | ||||||||||
|
||||||||||
Please read the dedicated [migration guide](../reference/filters-migration.md). | ||||||||||
Please read the dedicated [migration guide](./breaking-changes/5.12-filters.md). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
docs/deployment/breaking-changes/6.2-promote-to-indicator.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# Change to the observable "promote" API | ||
|
||
!!! info "" | ||
|
||
* **Deprecated in**: `OpenCTI 6.2` | ||
* **Removed in**: `OpenCTI 6.5` | ||
labo-flg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Description of changes | ||
|
||
The API calls that promote an Observable to Indicator now return the created Indicator instead of the original Observable. | ||
|
||
**GraphQL API** | ||
|
||
* Mutation `StixCyberObservableEditMutations.promote` is now deprecated | ||
* New Mutation `StixCyberObservableEditMutations.promoteToIndicator` introduced | ||
|
||
|
||
**Client-Python API** | ||
|
||
* Client-python method `client.stix_cyber_observable.promote_to_indicator` is now deprecated | ||
* New Client-python method `client.stix_cyber_observable.promote_to_indicator_v2` introduced | ||
|
||
|
||
## Migration guide | ||
|
||
If you are using custom scripts that make use of the deprecated API methods, please update these scripts. | ||
|
||
The changes are straightforward: if you are using the return value of the method, you should now expect the new Indicator | ||
instead of the Observable being promoted; adapt your code accordingly. |
16 changes: 16 additions & 0 deletions
16
docs/deployment/breaking-changes/6.2-saml-authentication.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Change to SAML authentication default parameters | ||
|
||
!!! info "" | ||
|
||
* **Changed in**: `OpenCTI 6.2` | ||
|
||
## Description of changes | ||
|
||
Upgrading `passport-saml` library introduced a breaking change with respect to the default SAML parameters regarding signing responses and assertions. | ||
|
||
When `want_assertions_signed` and `want_authn_response_signed` SAML parameter are not present in OpenCTI configuration, | ||
the default is now set to `true` by `passport-saml` library when previously it was `false` by default. | ||
|
||
## Migrate guide | ||
|
||
If you have issues after upgrade, you can try with both parameters set to `false`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need a a tag ? links are generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I've been copy-pasting how it's done elsewhere. Anchor links are not generated it seems.