Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deployment] improve breaking changes documentation #209

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Sep 20, 2024

Breaking changes docs shall be improved to clarify our deprecation, our breaking changes and provide clear access to migration guides.

@labo-flg labo-flg marked this pull request as draft September 20, 2024 15:32
@labo-flg
Copy link
Member Author

labo-flg commented Sep 20, 2024

cc @helene-nguyen I did not add the deprecation/breaking changes for connectors.
could you try to fit some explanation in this new model ?

A mention in the table, a brief section with a short description and a link to a dedicated guide.

cc @richard-julien @Kedae for awareness

@helene-nguyen
Copy link
Member

@labo-flg We will have deprecation for 6.4 concerning stream connector splitting, I will add this

@labo-flg labo-flg marked this pull request as ready for review September 28, 2024 21:31
@labo-flg
Copy link
Member Author

labo-flg commented Sep 28, 2024

I open for review so we start with this improved page and build on that.


Please note that the deprecated methods will be permanently removed in OpenCTI 6.5.
<a id="change-to-the-observable-promote-API"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need a a tag ? links are generated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I've been copy-pasting how it's done elsewhere. Anchor links are not generated it seems.

Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the links, I think we should keep the generated one

Comment on lines 37 to 40

#### How to migrate

If you have issues after upgrade, you can try with both parameters set to `false`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### How to migrate
If you have issues after upgrade, you can try with both parameters set to `false`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants