Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules needed by wms should not use config_loader #2580

Merged
merged 1 commit into from
Dec 6, 2024
Merged

modules needed by wms should not use config_loader #2580

merged 1 commit into from
Dec 6, 2024

Conversation

ReimarBauer
Copy link
Member

Purpose of PR?:

Fixes #2349

wms should not use modules which needs the config_loader from msui. A few functions extracted in own modules.

@ReimarBauer ReimarBauer requested a review from joernu76 December 2, 2024 15:16
joernu76
joernu76 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@joernu76 joernu76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one should have only moved find_location to the place in msui where it is used, as I dislike the resulting small submodules, but it accomplishes the intent.

@joernu76 joernu76 merged commit ca9db4a into Open-MSS:develop Dec 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joernu76 joernu76 joernu76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_projection_params and find_location has to become a standalone
2 participants
@ReimarBauer @joernu76