Allow non-items to be hinted via plando #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added
Type: Enhancement
Closed
fenhl
approved these changes
Feb 15, 2024
fenhl
added
Status: Needs Testing
fenhl
removed
the
Status: Waiting for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hint plandos only allow for things defined as items in ItemList.py as valid choices for the "item_hints" block. However other locations in the project allow for non-item defined options to be added to this block (see data/Bingo/generic_bingo_hints"). This PR allows for non-item defined choices to be used in a hint plando (songs, keys, etc). This can be tested via the following plando currently:
Valid types will be those that have an item declared that type in ItemList.py and a hint for that item in HintList.py