Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugfixes #2154

Closed
wants to merge 3 commits into from
Closed

Various bugfixes #2154

wants to merge 3 commits into from

Conversation

aofengen
Copy link

@aofengen aofengen commented Dec 21, 2023

There are two separate bugfixes in this PR:

  1. Currently hint plandos only allow for things defined as items in ItemList.py as valid choices for the "item_hints" block. However other locations in the project allow for non-item defined options to be added to this block (see data/Bingo/generic_bingo_hints"). This PR allows for non-item defined choices to be used in a hint plando (songs, keys, etc). This can be tested via the following plando currently:
"settings": {
	"item_hints":                              ["Zeldas Lullaby"]
}

Valid types will be those that have an item declared that type in ItemList.py and a hint for that item in HintList.py - This change is reflected in the changes to SettingsList.py

  1. The coop hint distribution is only used for the co-op tournament, but at present does not allow for generating any seeds because there aren't enough hints present and/or weights used. This fix changes the hint distro to generate valid seeds until the coop tournament admins are ready to update it for the next tournament. This change is reflected in data/hints/coop.json

@fenhl fenhl added Type: Enhancement New feature or request Component: Setting specific to setting(s) Component: Hints related to how we help the player labels Dec 22, 2023
SettingsList.py Outdated Show resolved Hide resolved
@aofengen aofengen changed the title Allow non-items to be hinted via plando Various bugfixes Dec 27, 2023
@aofengen aofengen closed this Dec 27, 2023
@aofengen
Copy link
Author

will reopen in a moment because past me is bad at github

@fenhl
Copy link
Collaborator

fenhl commented Dec 27, 2023

For reference: Reopened as #2157 and #2158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hints related to how we help the player Component: Setting specific to setting(s) Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants