Compatible with Qt5 #238
Compatible with Qt5 #238
Conversation
Updating QT to be buildable with QT5
|
Do the rosdep keys for qt4 resolve to qt5 though? In the package.xml, you only specify qt4, but then have a switch for qt5 in the CMake. |
|
You are right, ill fix it now |
| @@ -19,6 +19,8 @@ | |||
| <depend>libqt4-dev</depend> | |||
| <depend>libqt4-opengl-dev</depend> | |||
|
|
|||
| <depend>qtbase5-dev</depend> | |||
|
|
|||
There was a problem hiding this comment.
Do I need to replace it or add it as a new depend?
There was a problem hiding this comment.
I think add as another, but I haven't tested or looked into it deeply - just checked the correct rosdep key.
|
In terms of general Qt5 compability (so this is not only limited to the ROS use case), I would suggest separating the changes and targeting the devel branch. The goal should be a working "plain" Qt5 build (not ROS2 package) as first step. Please also have a look at the .travis.yml config for the CI. Before merging, the CI checks must succeed. |
|
In general, Qt5 compatibility was already merged in #152, so maybe this is just a case of adjust the Travis config (for the non-ROS2 use case)? |
No description provided.