Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt5 and travis #280

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Qt5 and travis #280

merged 3 commits into from
Jan 22, 2020

Conversation

jnumm
Copy link
Contributor

@jnumm jnumm commented Jan 21, 2020

Hi,

PR #238 seems to be stuck, so this one has the same CMake changes but does not touch ROS files while enabling Travis to build with Qt5.

Thanks to kazuki0824 and anasarrak.
Copied from root CMakeFiles.txt to make this flag default ON even if
building octovis as a module.
@ahornung ahornung merged commit 8a5aa0c into OctoMap:devel Jan 22, 2020
@ahornung
Copy link
Member

Thanks!

@wxmerkt
Copy link
Member

wxmerkt commented Jan 23, 2020

This PR broke the ROS builds as the rosdep keys weren't updated in the package.xml. It turns out libqglviewer-qt5 isn't a rosdep key yet, so first needs to be upstreamed to rosdistro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants