Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailing list to chapter schema #842 #967

Closed
wants to merge 11 commits into from
5 changes: 5 additions & 0 deletions schema/chapter.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
"minLength": 1,
"type": "string"
},
"mailing-list": {
"description": "The optional mailing list associated with the chapter.",
"format": "uri",
"type": "string"
},
"name": {
"description": "The unique name of the chapter.",
"minLength": 10,
Expand Down
3 changes: 3 additions & 0 deletions schema/tests/chapter_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@
("logo-null.yaml", "None is not of type 'array'"),
("meetup_group-empty.yaml", "'' should be non-empty"),
("meetup_group-null.yaml", "None is not of type 'string'"),
("mailing-list-empty.yaml", "'' is not a 'uri'"),
("mailing-list-invalid.yaml", "'https://xyz' is not a 'uri'"),
("mailing-list-null.yaml", "None is not a 'uri'"),
("name-empty.yaml", "'' is too short"),
("name-null.yaml", "None is not of type 'string'"),
("name-undefined.yaml", "'name' is a required property"),
Expand Down
15 changes: 15 additions & 0 deletions schema/tests/data/chapter/negative/mailing-list-empty.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
audience: builder
leaders:
- github: leader-name-1
name: Leader Name 1
- github: leader-name-2
name: Leader Name 2
level: 2
mailing-list: ''
name: Valid Chapter Name
pitch: A very brief, one-line description of your chapter
tags:
- example-tag-1
- example-tag-2
- example-tag-3
type: code
15 changes: 15 additions & 0 deletions schema/tests/data/chapter/negative/mailing-list-invalid.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
audience: builder
leaders:
- github: leader-name-1
name: Leader Name 1
- github: leader-name-2
name: Leader Name 2
level: 2
mailing-list: https://xyz
name: Valid Chapter Name
pitch: A very brief, one-line description of your chapter
tags:
- example-tag-1
- example-tag-2
- example-tag-3
type: code
15 changes: 15 additions & 0 deletions schema/tests/data/chapter/negative/mailing-list-null.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
audience: builder
leaders:
- github: leader-name-1
name: Leader Name 1
- github: leader-name-2
name: Leader Name 2
level: 2
mailing-list:
name: Valid Chapter Name
pitch: A very brief, one-line description of your chapter
tags:
- example-tag-1
- example-tag-2
- example-tag-3
type: code