Add mailing list to chapter schema #842 #967
Conversation
WalkthroughA new optional property, Changes
Sequence Diagram(s)sequenceDiagram
participant T as Test Runner
participant V as Schema Validator
participant D as Test Data Loader
T->>D: Load YAML test case (empty/invalid/null)
D-->>T: Provide test data
T->>V: Validate chapter schema with mailing_list value
V-->>T: Return validation result (error message if not a valid URI)
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
schema/chapter.json(1 hunks)schema/tests/chapter_test.py(1 hunks)schema/tests/data/chapter/negative/mailing-list-empty.yaml(1 hunks)schema/tests/data/chapter/negative/mailing-list-invalid.yaml(1 hunks)schema/tests/data/chapter/negative/mailing-list-null.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- schema/tests/data/chapter/negative/mailing-list-empty.yaml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
schema/tests/data/chapter/negative/mailing-list-invalid.yaml
[error] 15-15: no new line character at the end of file
(new-line-at-end-of-file)
schema/tests/data/chapter/negative/mailing-list-null.yaml
[error] 15-15: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (2)
schema/chapter.json (1)
60-64: Property addition looks good!The mailing-list property has been added with appropriate format and description. The implementation follows the same pattern as other URI-formatted properties in the schema.
schema/tests/chapter_test.py (1)
55-57: Test cases look good!The added test cases properly validate the mailing-list property for different invalid scenarios (empty string, invalid URI, and null value). These tests align well with the existing test patterns.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
schema/tests/data/chapter/negative/mailing-list-null.yaml (1)
15-15: Add a newline at the end of the file.
YAMLlint flagged the absence of a newline at the end. Please append a newline to ensure compliance with formatting standards.-type: code +type: code +🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 15-15: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
schema/tests/data/chapter/negative/mailing-list-null.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
schema/tests/data/chapter/negative/mailing-list-null.yaml
[error] 15-15: no new line character at the end of file
(new-line-at-end-of-file)
There was a problem hiding this comment.
Please follow https://github.com/OWASP/Nest/blob/main/CONTRIBUTING.md and test your code before requesting the review.
|
There was a problem hiding this comment.
I'm kindly asking again to run your tests locally first -- https://github.com/OWASP/Nest/actions/runs/13610987050/job/38048118221?pr=967
|
I have closed it for now because it runs the ci automatic after each update in your main i haven't pushed an update on my branch |
Resolves #842
Summary by CodeRabbit
New Features
Tests