Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ChatBot Functionality #69

Closed
wants to merge 2 commits into from

Conversation

Sarthak5598
Copy link
Member

No description provided.

Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not recommended to have commented code in the code base. Git allows to use commit entities if you need to revert something.

@@ -16,6 +16,7 @@ slackeventsapi = "^3.0.1"
slack-sdk = "^3.27.2"
openai = "^1.35.7"
cachetools = "^5.3.3"
pre-commit = "^3.7.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should go under dev section requirements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay!

@Sarthak5598
Copy link
Member Author

I commented it out as this functionality will be used in future, Is it still better to revert it ?

@arkid15r
Copy link
Contributor

I commented it out as this functionality will be used in future, Is it still better to revert it ?

I prefer to keep code clean and have comments for code explanation only. You can always dig git history and get those changes back when needed. It also may change and that functionality will be no longer needed but the commented code won't be taken care of.

@Sarthak5598
Copy link
Member Author

okay will revert it , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants