-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sale_loyalty_order_line_link: Migration to 17.0 #234
Open
arantxa-s73
wants to merge
23
commits into
OCA:17.0
Choose a base branch
from
Studio73:17.0-mig-sale_loyalty_order_line_link
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] sale_loyalty_order_line_link: Migration to 17.0 #234
arantxa-s73
wants to merge
23
commits into
OCA:17.0
from
Studio73:17.0-mig-sale_loyalty_order_line_link
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technical module linking order lines with programs TT30850
Filter lines that are related to a reward: either they genereted it or the reward is applied to them. For example: - A promotion product domain could be: ("id", "=" product_a.id) - The same promotion has a reward product B - On a sale order with products A, B and C: - A reward line will be generated to discount B's amount and will be linked to the promotion. - Line A will have a link to the reward line as it was the condition for the promotion. - Line B will also have a link to the reward line as it's the line over which the discount is made. TT31755
On the reward lines we can just invert the relation comlumns to have the lines that generated them. TT31755
We can now view which promotions are applied visually. TT35401
If a third module adds an extra discount scope, we should: - Allow integration returning always at least an empty object - Allow compatibility by inheritance hooking into the method that defines the scoped lines. TT36131
In some cases the `recompute_coupon_lines` method could lead to miss the previously created links. We want to ensure those links at the end of such method. TT40205
Currently translated at 100.0% (15 of 15 strings) Translation: sale-promotion-15.0/sale-promotion-15.0-sale_coupon_order_line_link Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_order_line_link/it/
…_link + Migration to version 16.0 TT44349
…test improvements TT44349
Currently translated at 100.0% (12 of 12 strings) Translation: sale-promotion-16.0/sale-promotion-16.0-sale_loyalty_order_line_link Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-16-0/sale-promotion-16-0-sale_loyalty_order_line_link/es/
Currently translated at 100.0% (12 of 12 strings) Translation: sale-promotion-16.0/sale-promotion-16.0-sale_loyalty_order_line_link Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-16-0/sale-promotion-16-0-sale_loyalty_order_line_link/it/
The alias in front of the column to be modified causes a conflict and is wrong.
Currently translated at 100.0% (12 of 12 strings) Translation: sale-promotion-16.0/sale-promotion-16.0-sale_loyalty_order_line_link Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-16-0/sale-promotion-16-0-sale_loyalty_order_line_link/it/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 17.0